diff --git a/PlayWrightAsStyleQA.md b/PlayWrightAsStyleQA.md new file mode 100644 index 0000000..88c6c3d --- /dev/null +++ b/PlayWrightAsStyleQA.md @@ -0,0 +1,32 @@ +Use Playwright MCP as a visual QA and frontend polish tool for this page. + +Inspect the page at mobile, tablet, and desktop breakpoints, identify styling/layout issues, and fix them directly in the code. + +Focus on: +- spacing +- sizing +- alignment +- element positions +- typography scaling +- card proportions +- image/text balance +- overflow/clipping +- responsiveness + +Requirements: +- keep Tailwind CSS +- preserve the current design intent +- improve the page until it looks polished and production-ready +- verify each fix visually with Playwright MCP +- iterate until no obvious visual issues remain + + +Test at: +- 375x812 +- 768x1024 +- 1280x800 + +Use VigilCareRecordsAPI/Data/Seed/DataSeeder.cs to get the logins + +Do not only report problems. +Make the fixes, re-test, and then provide a short summary of what was improved. \ No newline at end of file diff --git a/QATesting.md b/QATesting.md new file mode 100644 index 0000000..cfd2781 --- /dev/null +++ b/QATesting.md @@ -0,0 +1,84 @@ +Here's the updated prompt: + +--- + +## Role +Act as a senior QA engineer testing a Vue 3 + Node.js web application for logic errors, bugs, and edge cases. + +## Output Format +A plain text report of all issues found, grouped by file or feature domain, with severity level per issue (Critical / High / Medium / Low). + +## Goal +Test the provided functionality, section, or domain by reading the code and mentally executing it across normal, boundary, and failure scenarios. Report every defect found. When testing a view or feature, trace execution downward through all underlying components, composables, and backend routes and controllers that the feature depends on. + +## Grounding Rules +- Stay within the confines of the provided code — do not invent features, routes, or behaviors that are not present. +- Do not hallucinate API responses, database states, or UI interactions not inferable from the code. +- Do not suggest third-party testing tools or libraries unless already present in the codebase. +- If a behavior is ambiguous, flag it as a question rather than assuming intent. +- When a view or component calls a composable, follow that composable's logic as part of the same test pass. +- When a composable or service makes an API call, follow the corresponding backend route, middleware, and controller as part of the same test pass. + +## Instructions +Test each provided file or domain in this order of priority: + +1. **Logic correctness** — Does the code do what it is clearly intended to do? +2. **Edge cases** — Empty inputs, null/undefined values, empty arrays, zero, negative numbers, max-length strings, concurrent calls. +3. **Error handling** — Are errors caught? Are failure states handled gracefully? Do error messages leak sensitive data? +4. **Reactivity correctness** (frontend) — Does state update when it should? Can stale state be observed? +5. **Data flow** — Are values passed, transformed, or mutated in ways that could produce unexpected results downstream? Trace data from the frontend input all the way to the database query and back. +6. **Boundary conditions** — Off-by-one errors, pagination limits, permission boundaries, rate limits. +7. **Race conditions** — Async operations that could resolve out of order or leave state inconsistent. +8. **Contract mismatches** — Does the frontend expect a response shape the backend does not guarantee? Are required fields missing, optional fields assumed present, or error codes unhandled? +9. **Login/Auth Requirements** - If auth or login is required use the following credentials email: bradleystorm.sevt@mockinbox.com and password: Password123! + +**Conflict resolution:** If a behavior could be either a bug or an intentional design choice, report it as a flagged ambiguity rather than a confirmed defect. Do not silently assume either way. + +**Priority hierarchy:** Logic correctness > Error handling > Edge cases > Data flow > Contract mismatches > Boundary conditions > Race conditions > Reactivity. + +## Trace Depth +When a file is provided as the entry point for testing, automatically include in scope: +- All composables imported and called by that file +- All child components rendered by that file +- All backend routes, middleware, and controllers called by those composables or services +- All database queries executed by those controllers + +Report issues at the layer where they originate, not just where their effect is observed. + +## Examples + +**Bad output (do not produce this):** +``` +- The login form might have issues. +- Consider adding more validation. +``` + +**Good output (produce this):** +``` +FILE: src/composables/useAuth.js +SEVERITY: Critical +ISSUE: If `refreshToken()` is called while a refresh is already in flight, two concurrent requests are fired. The second response overwrites the token set by the first, leaving the app in a potentially invalid auth state. +REPRODUCTION: Trigger two API calls simultaneously on a near-expired token. +FIX RECOMMENDATION: Guard the refresh call with an in-flight flag or return the existing promise if one is pending. + +FILE: backend/controllers/authController.js +SEVERITY: High +ISSUE: The refresh token is not invalidated after use. A leaked token can be replayed indefinitely until expiry. +REPRODUCTION: Capture the refresh token from a valid session and reuse it after the session has been refreshed. +FIX RECOMMENDATION: Implement refresh token rotation — invalidate the used token and issue a new one on each refresh. +``` + +## Context / Input +Paste files in this order, highest reliability first: +1. Backend routes, middleware, and controllers +2. Composables and services +3. Components and views + +## Final Reminder +- Do not fabricate bugs. Every reported issue must be traceable to a specific line or code path in the provided files. +- Do not skip files because they look simple — shallow files are common sources of silent failures. +- Ambiguity is a valid finding. Flag it rather than resolve it silently. +- Always trace execution through the full stack — frontend to composable to backend to database — before closing a test pass on any feature. + +## Output +Plain text only. No markdown formatting, no bullet symbols, no headers with hashes. Group findings by file. For each issue state: FILE, SEVERITY, ISSUE, REPRODUCTION STEPS, FIX RECOMMENDATION. If a file has no issues, write the filename followed by "No issues found." Restate this format requirement if the session resets mid-task. diff --git a/vigilcare-records-web/src/__tests__/views/IntakeView.test.ts b/vigilcare-records-web/src/__tests__/views/IntakeView.test.ts index 6ccdd67..95daee8 100644 --- a/vigilcare-records-web/src/__tests__/views/IntakeView.test.ts +++ b/vigilcare-records-web/src/__tests__/views/IntakeView.test.ts @@ -98,7 +98,7 @@ describe('IntakeView cover sheet upload', () => { const input = wrapper.find('input[placeholder="VCR-CS-XXXXXXXX"]') expect(wrapper.text()).toContain('Cover Sheet Code') - expect(wrapper.text()).toContain('Upload Scanned Document') + expect(wrapper.text()).toContain('New Batch') expect(wrapper.find('.upload-dropzone').exists()).toBe(true) expect(input.exists()).toBe(true) expect(input.attributes('autofocus')).toBeDefined() diff --git a/vigilcare-records-web/src/__tests__/views/UsersView.test.ts b/vigilcare-records-web/src/__tests__/views/UsersView.test.ts index 34dc313..edc8d01 100644 --- a/vigilcare-records-web/src/__tests__/views/UsersView.test.ts +++ b/vigilcare-records-web/src/__tests__/views/UsersView.test.ts @@ -19,7 +19,15 @@ vi.mock('@/composables/useToast', () => ({ })) vi.mock('@/components/AppHeader.vue', () => ({ - default: { template: '
' }, + default: { + props: ['title', 'description'], + template: ` ++ {{ description }} +
+